Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Update test packages (major) #751

Merged
merged 2 commits into from
May 4, 2023
Merged

chore(deps): Update test packages (major) #751

merged 2 commits into from
May 4, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 20, 2023 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
jest-puppeteer (source) ^7.0.0 -> ^8.0.0 age adoption passing confidence
puppeteer (source) ^19.2.0 -> ^20.0.0 age adoption passing confidence

Release Notes

argos-ci/jest-puppeteer

v8.0.6

Compare Source

Bug Fixes

v8.0.5

Compare Source

Note: Version bump only for package jest-puppeteer

v8.0.4

Compare Source

Bug Fixes

v8.0.3

Compare Source

Bug Fixes

v8.0.2

Compare Source

Note: Version bump only for package jest-puppeteer

v8.0.1

Compare Source

Note: Version bump only for package jest-puppeteer

v8.0.0

Compare Source

Features
BREAKING CHANGES
    • spawnd now exports { spawd } instead of default to ensure
      compatibilty with ESM
  • toMatch has been renamed toMatchTextContent to avoid collision
    with existing Jest matcher

7.0.1 (2023-02-15)

Note: Version bump only for package jest-puppeteer

puppeteer/puppeteer

v20.1.0: puppeteer: v20.1.0

Compare Source

Miscellaneous Chores
  • puppeteer: Synchronize puppeteer versions
Dependencies
  • The following workspace dependencies were updated
    • dependencies
      • puppeteer-core bumped from 20.0.0 to 20.1.0

v20.0.0: puppeteer: v20.0.0

Compare Source

⚠ BREAKING CHANGES
  • switch to Chrome for Testing instead of Chromium (#​10054)
Features
Dependencies
  • The following workspace dependencies were updated

Configuration

📅 Schedule: Branch creation - "before 9am on Tuesday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner March 20, 2023 18:24
@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 17410f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renovate renovate bot force-pushed the renovate-major-test-packages branch 3 times, most recently from 6a0e0cf to 5e01b02 Compare March 22, 2023 03:39
@renovate renovate bot force-pushed the renovate-major-test-packages branch 5 times, most recently from eab0fb2 to a5abb9c Compare March 31, 2023 01:03
@renovate renovate bot force-pushed the renovate-major-test-packages branch 4 times, most recently from b831d65 to c17feeb Compare April 11, 2023 04:01
askoufis
askoufis previously requested changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@askoufis askoufis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for now. For some reason sku's custom snapshot serializers aren't being used anymore. jestSetup.js is definitely running though.

@askoufis askoufis dismissed their stale review April 11, 2023 06:37

Nevermind, just needed to do a force install. User error I guess.

askoufis
askoufis previously requested changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@askoufis askoufis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think something is broken. My comment above still stands, custom snapshot serializers are not being used for some reason, despite jest setup running.

@askoufis askoufis force-pushed the renovate-major-test-packages branch from 97e9783 to 7729aaf Compare April 13, 2023 05:14
@renovate renovate bot force-pushed the renovate-major-test-packages branch 7 times, most recently from 6095279 to 68aa080 Compare April 21, 2023 04:07
@renovate renovate bot force-pushed the renovate-major-test-packages branch 5 times, most recently from 5d707d1 to 5c7a7e6 Compare May 2, 2023 04:06
@renovate renovate bot force-pushed the renovate-major-test-packages branch 2 times, most recently from 31a0c00 to 424d143 Compare May 2, 2023 19:00
@renovate renovate bot changed the title chore(deps): Update dependency jest-puppeteer to v8.x chore(deps): Update test packages (major) May 2, 2023
@renovate renovate bot force-pushed the renovate-major-test-packages branch from 424d143 to e27bf6d Compare May 3, 2023 06:00
@renovate
Copy link
Contributor Author

renovate bot commented May 3, 2023 •
edited
Loading

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: pnpm-lock.yaml
installing v2 tool node v14.17.4
updating node-gyp
+ node-gyp@9.3.1
added 74 packages from 44 contributors and updated 2 packages in 6.021s
linking tool node v14.17.4
node: v14.17.4 /usr/local/bin/node
npm: 6.14.14  /usr/local/bin/npm
Installed v2 /usr/local/buildpack/tools/v2/node.sh in 10 seconds
installing v2 tool pnpm v8.4.0
+ pnpm@8.4.0
added 1 package in 0.89s
linking tool pnpm v8.4.0
ERROR: This version of pnpm requires at least Node.js v16.14
The current version of Node.js is v14.17.4
Visit https://r.pnpm.io/comp to see the list of past pnpm versions with respective Node.js version support.

@renovate renovate bot force-pushed the renovate-major-test-packages branch 2 times, most recently from 6a7808a to 103abb9 Compare May 4, 2023 05:00
@askoufis
Copy link
Contributor

askoufis commented May 4, 2023 •
edited
Loading

jest-puppeteer definitely had a regression (likely in the v8 release).

Made an issue upstream argos-ci/jest-puppeteer#552.

We could workaround this for now by moving the snapshot serializer config to the jest config.

@renovate renovate bot force-pushed the renovate-major-test-packages branch from 103abb9 to b391e6a Compare May 4, 2023 05:20
@askoufis
Copy link
Contributor

askoufis commented May 4, 2023 •
edited
Loading

We could workaround this for now by moving the snapshot serializer config to the jest config.

Did this in 17410f8. This required moving each serializer into its own file. Didn't move the serializer that we use for the import-order tests as that one barely affects the snapshot output, unlike the other serializers.

@askoufis askoufis dismissed their stale review May 4, 2023 05:47

Fixed it

@askoufis askoufis merged commit 8da1ee8 into master May 4, 2023
@askoufis askoufis deleted the renovate-major-test-packages branch May 4, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askoufis askoufis askoufis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@askoufis